Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update generic templates #2547

Merged
merged 5 commits into from
Aug 14, 2019
Merged

Update generic templates #2547

merged 5 commits into from
Aug 14, 2019

Conversation

rohanjr
Copy link
Contributor

@rohanjr rohanjr commented Aug 14, 2019

Incorporate fixes from digital-asset/ghc#33.

Fixes #2239

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Add a line to the release notes, if appropriate
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@rohanjr rohanjr requested review from a user, hurryabit and akalburgi August 14, 2019 19:15
@rohanjr rohanjr self-assigned this Aug 14, 2019
@rohanjr rohanjr merged commit 5bf86db into master Aug 14, 2019
@rohanjr rohanjr deleted the update-generic-templates branch August 14, 2019 20:28
@ghost ghost mentioned this pull request Aug 15, 2019
Closed
hurryabit
hurryabit reviewed Aug 15, 2019
View reviewed changes
Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks.
I'm looking forward to the examples and the docs.

compiler/damlc/tests/daml-test-files/ProposalIou.daml
@@ -42,7 +42,7 @@ test = scenario do
lookupByKey @(Proposal Iou) ([bank], "present")
mbPropId === Some propId
iouId <- submit alice do
exercise propId (Accept @Iou)
exercise propId Accept
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hurryabit hurryabit hurryabit left review comments

@akalburgi akalburgi akalburgi approved these changes

Assignees

@rohanjr rohanjr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a docs marker when desugaring template instance.
3 participants
@rohanjr @hurryabit @akalburgi