Daml stdlib with versions #2479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
daml_stdlib_with_versions
branch
from
4da3e5a to
a8e65e6
Compare
ghost
force-pushed
the
daml_stdlib_with_versions
branch
from
c48f150 to
055f2b1
Compare
hurryabit
approved these changes
Aug 12, 2019
| if [ "daml-prim" = {pkg_name} ]; then | ||
| echo {pkg_name} > {pkg_name_version_file} | ||
| else | ||
| echo {pkg_name}-`cat {sdk_version_file}` > {pkg_name_version_file} |
There was a problem hiding this comment.
Suggested change
| echo {pkg_name}-`cat {sdk_version_file}` > {pkg_name_version_file} | |
| echo -n {pkg_name} > {pkg_name_version_file} | |
| cat {sdk_version_file} >> {pkg_name_version_file} |
ghost
force-pushed
the
daml_stdlib_with_versions
branch
3 times, most recently
from
fa515f1 to
00b04a2
Compare
ghost
force-pushed
the
daml_stdlib_with_versions
branch
from
00b04a2 to
92f5797
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds versions to the daml-stdlib name so we avoid name clashes when different packages import different versions of the stdlib.
Pull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.