-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
record Nick's comments on hs ledger bindings #2340
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like docs, thanks!
|
||
To use the bindings in this repo, you need the following `BUILD` dep: | ||
``` | ||
"//language-support/hs/bindings:hs-ledger", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would make the in this repo
part bold and maybe point out explicitly that this is only for this repo since I don’t expect that most people will use it in the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I've also switched the order, which I believe reads better as a logical sequence: how the code is structured, how to use in repo, how to use out of repo. (As opposed to previous commit which had how to use outside, how code is structured, how to use inside.)
2e8f86c
to
b652cd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff. Thanks for doing this Gary.
|
||
You can find some usage examples | ||
[here](/language-support/hs/bindings/test/DA/Ledger/Tests.hs) and | ||
[here](/language-support/hs/bindings/examples/chat/src/DA/Chat/ChatLedger.hs). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link is broken for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be /language-support/hs/bindings/examples/chat/src/DA/Ledger/App/Chat/ChatLedger.hs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in #2349.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Thanks.
|
||
You can find some usage examples | ||
[here](/language-support/hs/bindings/test/DA/Ledger/Tests.hs) and | ||
[here](/language-support/hs/bindings/examples/chat/src/DA/Chat/ChatLedger.hs). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be /language-support/hs/bindings/examples/chat/src/DA/Ledger/App/Chat/ChatLedger.hs
@nickchapman-da's response to @bame-da asking about Haskell ledger bindings documentation on Slack, with small adjustments for GitHub formatting.