Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unhide GHC.Classes docs and move them to Prelude. #2333

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Unhide GHC.Classes docs and move them to Prelude. #2333

merged 1 commit into from
Jul 30, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jul 30, 2019

  • Unhide GHC.Classes docs and move them to Prelude. These were hidden a long time ago for some reason (it was pre-repo move). This makes the docs for Eq and Ord visible, as well as not, && and ||.
  • Hiding IP since it doesn't seem like something we want in the DAML stdlib docs.

@ghost ghost requested review from cocreature and hurryabit July 30, 2019 10:45
@ghost ghost changed the title Unhide and move GHC.Classes docs to Prelude. Unhide GHC.Classes docs and move them to Prelude. Jul 30, 2019
cocreature
cocreature approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ghost ghost added the automerge label Jul 30, 2019
@mergify mergify bot merged commit 29fa387 into master Jul 30, 2019
@mergify mergify bot deleted the unhide-ghc-classes branch July 30, 2019 11:15
hurryabit
hurryabit reviewed Jul 30, 2019
View reviewed changes
Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks a lot.

compiler/damlc/daml-prim-src/GHC/Classes.daml
@@ -66,7 +66,7 @@ infixr 2 ||

default () -- Double isn't available yet

-- | The syntax `?x :: a` is desugared into `IP "x" a`
-- | HIDE The syntax `?x :: a` is desugared into `IP "x" a`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cocreature @hurryabit