Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hlb, no wildcard record construction #2332

Merged
merged 2 commits into from
Jul 30, 2019
Merged

hlb, no wildcard record construction #2332

merged 2 commits into from
Jul 30, 2019

Conversation

nickchapman-da
Copy link
Contributor

Address code review comments on last PR

Pull Request Checklist

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@nickchapman-da nickchapman-da requested a review from hurryabit July 30, 2019 09:01
@nickchapman-da nickchapman-da changed the title Hlb no wildcard record construction hlb, no wildcard record construction Jul 30, 2019
hurryabit
hurryabit approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks a lot.

@nickchapman-da nickchapman-da merged commit 8b5cd61 into master Jul 30, 2019
@nickchapman-da nickchapman-da deleted the hlb-no-wildcard-record-construction branch July 30, 2019 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hurryabit hurryabit hurryabit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickchapman-da @hurryabit