Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve haskell module hierarchy to be more consistent #2319

Merged
merged 1 commit into from
Jul 29, 2019
Merged

improve haskell module hierarchy to be more consistent #2319

merged 1 commit into from
Jul 29, 2019

Conversation

nickchapman-da
Copy link
Contributor

As per proposal...

compiler/lsp-tests/src/Daml/Lsp/Test/                               :module Daml.Lsp.Test           --> DA.Daml.Lsp.Test
daml-assistant/src/DAML/Assistant/                                  :module DAML.Assistant          --> DA.Daml.Assistant
daml-assistant/daml-project-config/DAML/Project/                    :module DAML.Project            --> DA.Daml.Project
daml-assistant/daml-helper/src/DamlHelper/                          :module DamlHelper              --> DA.Daml.Helper
language-support/hs/bindings/examples/nim/src/DA/Nim/               :module DA.Nim                  --> DA.Ledger.App.Nim
language-support/hs/bindings/examples/chat/src/DA/Chat/             :module DA.Chat                 --> DA.Ledger.App.Chat

Pull Request Checklist

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@nickchapman-da nickchapman-da requested review from a user and cocreature July 29, 2019 13:54
cocreature
cocreature approved these changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

ghost
ghost approved these changes Jul 29, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

hurryabit
hurryabit approved these changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@nickchapman-da nickchapman-da merged commit b90862e into master Jul 29, 2019
@nickchapman-da nickchapman-da deleted the haskell-code-use-consistent-module-hierarchy branch July 29, 2019 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hurryabit hurryabit hurryabit approved these changes

@cocreature cocreature cocreature approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickchapman-da @cocreature @hurryabit