Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

damldocs: Drop --json flag, update release notes. #2309

Merged
merged 2 commits into from
Jul 29, 2019
Merged

damldocs: Drop --json flag, update release notes. #2309

merged 2 commits into from
Jul 29, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jul 29, 2019

Based on @jberthold-da's comments on the last PR.

  • Drop the --json flag (in favor of --format=json)
  • Updates the release notes (should have been updated last PR, but better late than never).

@ghost ghost requested review from cocreature, hurryabit and jberthold-da July 29, 2019 06:03
jberthold-da
jberthold-da reviewed Jul 29, 2019
View reviewed changes
Copy link
Contributor

@jberthold-da jberthold-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we make this --json switch the flag for the input format?

@ghost
Copy link
Author

ghost commented Jul 29, 2019

Can't we make this --json switch the flag for the input format?

We already have --input-format=json which does just that. I don't think we should have multiple ways to set things like this, which is why I'm in favor of dropping --json altogether.

cocreature
cocreature approved these changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! I agree that -tinput-format=json is better than --json.

@ghost ghost added the automerge label Jul 29, 2019
@mergify mergify bot merged commit 2a17b3d into master Jul 29, 2019
@mergify mergify bot deleted the damldocs-drop-json-flag branch July 29, 2019 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hurryabit hurryabit Awaiting requested review from hurryabit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cocreature @jberthold-da