Revert "add old releases to hubspot (#2290)" #2308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ec70bbc.
cocreature
approved these changes
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Friday evening, we have four runs of the cron job that have produced the following logs (after a change of token, which may or may not be related):
With the net result that:
Because old releases are already there and the HubSpot API has proven to be unreliable, I would like to revert to the previous approach, which was only pushing to HubSpot after updating the documentation (and therefore does not rely on the HubSpot API to detect when a new post needs to be made).
Note: this would push a new HubSpot blog post (and therefore tweet) when we pull out a release too (i.e. on each change to versions.json), which I'm not sure how I feel about.