hlb, support: PartyManagementService #2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hurryabit
reviewed
Jul 29, 2019
| >>= \case | ||
| Right LL.SubmitAndWaitForTransactionIdResponse{} -> return $ Right () | ||
| Left details -> return $ Left $ show $ unStatusDetails details | ||
| <&> fmap (\LL.SubmitAndWaitForTransactionIdResponse{} -> ()) |
There was a problem hiding this comment.
FYI, Data.Functor and Contol.Monad export
void :: Functor f => f a -> f ()
void = fmap (const ())You might use that.
| @@ -59,7 +53,7 @@ submitAndWaitForTransaction commands = | |||
| Right response -> | |||
| either (fail . show) (return . Right) $ raiseResponse response | |||
| Left details -> | |||
| return $ Left $ show $ unStatusDetails details | |||
| return $ Left details | |||
There was a problem hiding this comment.
We have quite a few functions returning LedgerService (Either _ _). Would it make sense to move the error handling capabilities into the LedgerService monad?
There was a problem hiding this comment.
I don't think so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.