Upgrade hlint #2235
Merged
Upgrade hlint #2235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
cocreature
approved these changes
Jul 22, 2019
| @@ -526,7 +526,7 @@ hazel_repositories( | |||
| # - To build the library : `bazel build @haskell_hlint//:lib` | |||
| # We'll be using it via the library, not the binary. | |||
| hazel_hackage("haskell-src-exts", "1.21.0", "95dac187824edfa23b6a2363880b5e113df8ce4a641e8a0f76e6d45aaa699ff3") + | |||
| hazel_github_external("ndmitchell", "hlint", "9589299bf9a6273fe7c2915da3f9b7c35f82d527", "49386869b32cf1ccf8241ce9fe927d14475bd693e769ad65670715d3401a959f") + | |||
| hazel_github_external("shayne-fletcher-da", "hlint", "699adc7c7be5f876433a49661311093c42259cf1", "1fe563fa724ce589b85d67349d98ce254e01cfe28bda8bcf46958d944987e2cb") + | |||
There was a problem hiding this comment.
Should we have a fork under digital-asset?
hurryabit
approved these changes
Jul 22, 2019
| @@ -526,7 +526,7 @@ hazel_repositories( | |||
| # - To build the library : `bazel build @haskell_hlint//:lib` | |||
| # We'll be using it via the library, not the binary. | |||
| hazel_hackage("haskell-src-exts", "1.21.0", "95dac187824edfa23b6a2363880b5e113df8ce4a641e8a0f76e6d45aaa699ff3") + | |||
| hazel_github_external("ndmitchell", "hlint", "9589299bf9a6273fe7c2915da3f9b7c35f82d527", "49386869b32cf1ccf8241ce9fe927d14475bd693e769ad65670715d3401a959f") + | |||
| hazel_github_external("shayne-fletcher-da", "hlint", "699adc7c7be5f876433a49661311093c42259cf1", "1fe563fa724ce589b85d67349d98ce254e01cfe28bda8bcf46958d944987e2cb") + | |||
|
Great! I'll take it with @garyverhaegen-da and get it set up. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings DAML level with hlint head. It pulls in naming and import rules. There is one slight problem : as the GHC and DAML parse trees are divergent, hlint upstream is incompatible in
Naming.hswith the DAML version ofghc-lib. This requires patching hlint (theMatchconstructor has 5 arguments rather than 4 in our version to account for optional function return type signatures). I've done this on theda-masterbranch of my fork and updatedWORKSPACEto fetch hlint from there for the time being.