Wait for index before completing package upload #2194
Conversation
rautenrieth-da
force-pushed
the
package-upload-wait-for-index
branch
from
dd90709 to
b55b41a
Compare
...r/sandbox/src/main/scala/com/digitalasset/platform/sandbox/services/admin/PollingUtils.scala
Outdated
Show resolved
Hide resolved
| * @param ids The IDs of the uploaded packages | ||
| * @return The result of the party allocation received originally, wrapped in a [[Future]] | ||
| */ | ||
| private def pollUntilPersisted( |
There was a problem hiding this comment.
Do you think it would make sense to move this in PollingUtils?
There was a problem hiding this comment.
If you prefer to leave it here, it may be worth to cut on the parameters and call PollingUtils.pollUntilPersisted with the actual values here.
There was a problem hiding this comment.
Since we use the same values for minWait, maxWait, and backoffProgression, we could also hard-code them inside PollingUtils.pollUntilPersisted. If we realize that we need different values for party and package checking, we can put them as parameters, but I doubt that will be the case.
There was a problem hiding this comment.
The test uses explicit values for minWait, maxWait, and backoffProgression to check whether they behave correctly, so I will leave the parameters for now.
...ain/scala/com/digitalasset/platform/sandbox/services/admin/ApiPackageManagementService.scala
Outdated
Show resolved
Hide resolved
.../main/scala/com/digitalasset/platform/sandbox/services/admin/ApiPartyManagementService.scala
Outdated
Show resolved
Hide resolved
| iteration, | ||
| scheduler) | ||
| .map { numberOfAttempts => | ||
| logger.debug(s"Party $newParty available, read after $numberOfAttempts attempt(s)") |
There was a problem hiding this comment.
Would it make sense to move this to the helper function itself somehow? Would that be possible?
...r/sandbox/src/main/scala/com/digitalasset/platform/sandbox/services/admin/PollingUtils.scala
Outdated
Show resolved
Hide resolved
This makes sure users can immediately query the new packages after the upload completed. Fixes #2066
…x/services/admin/PollingUtils.scala Co-Authored-By: Stefano Baghino <43749967+stefanobaghino-da@users.noreply.github.com>
…x/services/admin/PollingUtils.scala Co-Authored-By: Stefano Baghino <43749967+stefanobaghino-da@users.noreply.github.com>
…x/services/admin/ApiPackageManagementService.scala Co-Authored-By: Stefano Baghino <43749967+stefanobaghino-da@users.noreply.github.com>
…x/services/admin/ApiPartyManagementService.scala Co-Authored-By: Stefano Baghino <43749967+stefanobaghino-da@users.noreply.github.com>
rautenrieth-da
force-pushed
the
package-upload-wait-for-index
branch
2 times, most recently
from
7cf3e66 to
3683099
Compare
rautenrieth-da
force-pushed
the
package-upload-wait-for-index
branch
from
3683099 to
848717a
Compare
This PR factors out the main polling function of
ApiPartyManagementServiceinto a separate helper, and uses it from bothApiPartyManagementServiceandApiPackageManagementService.This makes sure users can immediately query new packages after the upload completed.
Fixes #2066