Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve doc about enum types #2168

Merged
merged 2 commits into from
Jul 16, 2019
Merged

improve doc about enum types #2168

merged 2 commits into from
Jul 16, 2019

Conversation

remyhaemmerle-da
Copy link
Collaborator

improve release notes and update daml-lf-translation.rst

Pull Request Checklist

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@remyhaemmerle-da remyhaemmerle-da added this to the Maintenance milestone Jul 16, 2019
@remyhaemmerle-da remyhaemmerle-da changed the title add a more meat to doc about enum types improve doc about enum types Jul 16, 2019
stefanobaghino-da
stefanobaghino-da approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@stefanobaghino-da stefanobaghino-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one remark, minor and easy to apply. 😉

docs/source/app-dev/daml-lf-translation.rst Outdated Show resolved Hide resolved
@remyhaemmerle-da @stefanobaghino-da
Update docs/source/app-dev/daml-lf-translation.rst
31becc6 
Co-Authored-By: Stefano Baghino <43749967+stefanobaghino-da@users.noreply.github.com>
@mergify mergify bot merged commit 3a93647 into master Jul 16, 2019
@mergify mergify bot deleted the daml-lf-translation-doc branch July 16, 2019 16:19
hurryabit
hurryabit reviewed Jul 16, 2019
View reviewed changes
Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hurryabit hurryabit hurryabit left review comments

@stefanobaghino-da stefanobaghino-da stefanobaghino-da approved these changes

@bethaitman bethaitman Awaiting requested review from bethaitman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Maintenance
Development

Successfully merging this pull request may close these issues.
3 participants
@remyhaemmerle-da @hurryabit @stefanobaghino-da