haskell ledger bindings, support uploadDarFile #2146
Conversation
|
|
||
|
|
||
| -- Would be nice if the underlying service returned the pid on successful upload. | ||
| uploadDarFileGetPid :: LedgerId -> BS.ByteString -> LedgerService (Either String PackageId) |
There was a problem hiding this comment.
That looks like a race condition. What if someone else uploads something in the meantime? Given that we have the package it seems like we can do better even without an API change in the underlying service.
A more important issue: Is this guaranteed to always return a single package id? What if I upload a DAR with multiple packages (e.g. one that has several dependencies). Will they not show up in listPackages?
There was a problem hiding this comment.
You are probably right on both points.
I'll move this function into Test.hs & say it's ok because the caller knows.
There was a problem hiding this comment.
Thanks! Having this in the tests is totally reasonable.
| import DA.Ledger.LedgerService | ||
| import Network.GRPC.HighLevel.Generated | ||
|
|
||
| uploadDarFile :: ByteString -> LedgerService (Either String ()) -- Unlike other services, no LedgerId is needed. (why?!) |
There was a problem hiding this comment.
Can we get a haddock comment here that explains when you will get back Left?
Haskell ledger bindings:
UploadDarFileRPC ofpackage_management_servicePull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.