Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rules_haskell #2105

Merged
merged 1 commit into from
Jul 11, 2019
Merged

Update rules_haskell #2105

merged 1 commit into from
Jul 11, 2019

Conversation

aherrmann-da
Copy link
Contributor

Support for static GHC has been merged upstream.

Pull Request Checklist

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@aherrmann-da aherrmann-da requested a review from cocreature July 11, 2019 09:11
WORKSPACE Outdated
@@ -280,6 +280,7 @@ haskell_register_ghc_nixpkgs(
],
repositories = dev_env_nix_repos,
version = "8.6.5",
is_static = True,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer auto-detected. See tweag/rules_haskell#970 (review).

Support for static GHC has been merged upstream.
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@aherrmann-da aherrmann-da merged commit 80c449d into master Jul 11, 2019
@aherrmann-da aherrmann-da deleted the update-rh branch July 11, 2019 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants