Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all damlc tests to compiler/damlc/tests #2057

Merged
merged 1 commit into from
Jul 9, 2019
Merged

Conversation

cocreature
Copy link
Contributor

I’ve also changed some of the names to be more sensible.

Pull Request Checklist

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@cocreature cocreature requested review from a user July 9, 2019 10:55
@cocreature cocreature requested a review from hurryabit as a code owner July 9, 2019 10:55
I’ve also changed some of the names to be more sensible.
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍏

Thanks!

@@ -3,7 +3,7 @@

load("//bazel_tools:haskell.bzl", "da_haskell_test")

def _daml_ghc_compile_test_impl(ctx):
def _damlc_compile_test_impl(ctx):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cocreature cocreature merged commit 2371d17 into master Jul 9, 2019
@dasormeter dasormeter deleted the move-damlc-tests branch September 4, 2019 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant