Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get hlint into the build system #2039

Merged
merged 3 commits into from
Jul 8, 2019
Merged

Get hlint into the build system #2039

merged 3 commits into from
Jul 8, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jul 8, 2019

This PR makes hlint available in bazel build rules.

@ghost ghost requested review from cocreature and aherrmann-da July 8, 2019 16:23
cocreature
cocreature approved these changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

aherrmann-da
aherrmann-da approved these changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@aherrmann-da aherrmann-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aherrmann-da
aherrmann-da reviewed Jul 8, 2019
View reviewed changes
WORKSPACE Outdated Show resolved Hide resolved
@ghost ghost added the automerge label Jul 8, 2019
@mergify mergify bot merged commit b6daa2d into master Jul 8, 2019
@mergify mergify bot deleted the hlint-bazel-integration branch July 8, 2019 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cocreature @aherrmann-da