Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DivulgenceIT work with the test tool #2002

Merged
merged 1 commit into from
Jul 4, 2019
Merged

Make DivulgenceIT work with the test tool #2002

merged 1 commit into from
Jul 4, 2019

Conversation

gerolf-da
Copy link
Contributor

@gerolf-da gerolf-da commented Jul 4, 2019

  1. Change to SuiteResourceManagementAroundAll, transforming the test to
    not assume a new/empty ledger for each test case
  2. Use distinct workflow ids so the individual test cases don't clash
    with each other
  3. Use a new UUID for each randomized command id, instead of using the
    uuid used per test run.

Pull Request Checklist

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@gerolf-da gerolf-da added the component/dlik DAML Ledger Integration Kit label Jul 4, 2019
@gerolf-da gerolf-da requested a review from rautenrieth-da as a code owner July 4, 2019 09:43
@gerolf-da gerolf-da force-pushed the divulgenceit branch 2 times, most recently from b8b6343 to c869776 Compare July 4, 2019 10:51
Copy link
Contributor

@gabor-aranyossy gabor-aranyossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

1) Change to SuiteResourceManagementAroundAll, transforming the test to
not assume a new/empty ledger for each test case
2) Use distinct workflow ids so the individual test cases don't clash
with each other
3) Use a new UUID for each randomized command id, instead of using the
uuid used per test run.
@gerolf-da gerolf-da merged commit 399cab7 into master Jul 4, 2019
@gerolf-da gerolf-da deleted the divulgenceit branch July 4, 2019 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/dlik DAML Ledger Integration Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants