Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DamlOnXSubmissionService shuts down ExecutorService on close #1999

Merged

Conversation

oliverse-da
Copy link
Contributor

Pull Request Checklist

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

Sorry, something went wrong.

@oliverse-da oliverse-da added the component/dlik DAML Ledger Integration Kit label Jul 3, 2019
@oliverse-da oliverse-da requested review from a user, mziolekda and rautenrieth-da July 3, 2019 18:19
@oliverse-da oliverse-da requested a review from gerolf-da as a code owner July 3, 2019 18:19
@oliverse-da oliverse-da force-pushed the damlonx-submission-service-package-load-executor-shutdown branch 5 times, most recently from 8b4d7fd to 83fc653 Compare July 5, 2019 14:38
Copy link
Contributor

@mziolekda mziolekda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

@oliverse-da oliverse-da force-pushed the damlonx-submission-service-package-load-executor-shutdown branch from 83fc653 to 5742e0f Compare July 8, 2019 05:59
@oliverse-da oliverse-da merged commit 33695b9 into master Jul 8, 2019
@oliverse-da oliverse-da deleted the damlonx-submission-service-package-load-executor-shutdown branch July 8, 2019 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/dlik DAML Ledger Integration Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants