Remove zip-archive override and upgrade stackage snapshot #1920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The override of zip-archive was required at some point because the new version added additional safety checks that blew up in our tests. The codepaths affected by this are long gone so let’s just use whatever is in stackage. While I was touching packages anyway, I’ve also upgraded to the latest snapshot in the LTS we are currently following.
cocreature
force-pushed
the
package-cleanup
branch
from
5525595 to
d726eee
Compare
neil-da
approved these changes
Jun 27, 2019
|
Merging this is now since everyone is about to do a bazel expunge anyway, so we might as well give them a solid cache when they do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The override of zip-archive was required at some point because the new
version added additional safety checks that blew up in our tests. The
codepaths affected by this are long gone so let’s just use whatever is
in stackage.
While I was touching packages anyway, I’ve also upgraded to the latest
snapshot in the LTS we are currently following.
Pull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.