clenup LF versions java codegen test #18689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remyhaemmerle-da
force-pushed
the
remy-codegen-clean
branch
from
6937a8e to
30910b4
Compare
remyhaemmerle-da
changed the title
remyhaemmerle-da
commented
Mar 8, 2024
Comment on lines
-333
to
-346
| java_test( | ||
| name = "integration-tests-contract-keys", | ||
| srcs = [contract_keys_test], | ||
| test_class = "com.daml.ContractKeysTest", | ||
| deps = [ | ||
| ":integration-tests-model-2.dev", | ||
| "//canton:bindings-java", | ||
| "@maven//:com_google_protobuf_protobuf_java", | ||
| "@maven//:org_junit_jupiter_junit_jupiter_api", | ||
| "@maven//:org_junit_jupiter_junit_jupiter_engine", | ||
| "@maven//:org_junit_platform_junit_platform_commons", | ||
| "@maven//:org_junit_platform_junit_platform_runner", | ||
| ], | ||
| ) |
There was a problem hiding this comment.
no need to create a special case for contract key, just need to make it a 2.dev test.
There was a problem hiding this comment.
Oh right! I did this change mechanically without looking at the larger picture.
paulbrauner-da
approved these changes
Mar 8, 2024
Comment on lines
-333
to
-346
| java_test( | ||
| name = "integration-tests-contract-keys", | ||
| srcs = [contract_keys_test], | ||
| test_class = "com.daml.ContractKeysTest", | ||
| deps = [ | ||
| ":integration-tests-model-2.dev", | ||
| "//canton:bindings-java", | ||
| "@maven//:com_google_protobuf_protobuf_java", | ||
| "@maven//:org_junit_jupiter_junit_jupiter_api", | ||
| "@maven//:org_junit_jupiter_junit_jupiter_engine", | ||
| "@maven//:org_junit_platform_junit_platform_commons", | ||
| "@maven//:org_junit_platform_junit_platform_runner", | ||
| ], | ||
| ) |
There was a problem hiding this comment.
Oh right! I did this change mechanically without looking at the larger picture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.