Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the hie-bios commit SHA #1825

Merged
5 commits merged into from
Jun 22, 2019
Merged

Update the hie-bios commit SHA #1825

5 commits merged into from
Jun 22, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jun 22, 2019

Might not have been necessary in the end to get hie-core working in emacs but as @cocreature says, there have been many fixes so this is probably a good idea anyway.

@ghost ghost requested review from cocreature and neil-da June 22, 2019 14:20
@ghost ghost requested a review from hurryabit as a code owner June 22, 2019 14:20
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It would be great if you could also update the hash used by Bazel so the two stay in sync

daml/WORKSPACE

Line 551 in e63b012

"9f9fe00591c429c410475349560252ca7e622f1b",

WORKSPACE Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Jun 22, 2019

@moritzkiefer-da looks like this induces some required source code changes. Let's pick it up Monday.

@ghost
Copy link
Author

ghost commented Jun 22, 2019

The last commit adds some tutorial documentation on Emacs integration.

@cocreature
Copy link
Contributor

@shayne-fletcher-da I’ve pushed a fix for the errors you got.

@@ -0,0 +1,50 @@
# How to get `hie-core` working in Emacs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just fling this as a section in the normal readme for hie-core. I wouldn't have thought of hunting for an emacs specific one.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy that @neil-da. I'll take care of it Monday. Initial doc. was just to get something going. I'll make it nice and integrate.

@ghost
Copy link
Author

ghost commented Jun 22, 2019

@shayne-fletcher-da I’ve pushed a fix for the errors you got.

@moritzkiefer-da , 🎸 !

@ghost ghost merged commit c8e7af5 into master Jun 22, 2019
@ghost ghost deleted the hie-bios-update branch June 22, 2019 16:36
hsenag pushed a commit to hsenag/daml that referenced this pull request Sep 13, 2019
* Update the hie-bios commit SHA

* Also update the SHA in our bazel WORKSPACE

* Update the hash too

* Tutorial for Emacs integration

* Update hie-bios patch
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants