Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update copyright #18167

Merged
merged 3 commits into from
Jan 15, 2024
Merged

update copyright #18167

merged 3 commits into from
Jan 15, 2024

Conversation

garyverhaegen-da
Copy link
Contributor

No description provided.

Copy link
Contributor

@mziolekda mziolekda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although CI has found some mpre exampes in infra e.g.

infra/azure.tf: notice text mismatch:
  actual  : # Copyright (c) 2023 Digital Asset (Switzerland) GmbH and/or its affiliates. All rights reserved.
  expected: # Copyright (c) 2024 Digital Asset (Switzerland) GmbH and/or its affiliates. All rights reserved.

garyverhaegen-da added a commit that referenced this pull request Jan 15, 2024
@akrmn
Copy link
Contributor

akrmn commented Jan 15, 2024

Since this PR changes the copyright comment in compiler/damlc/tests/PlatformIndependence.daml, this breaks the precheck //compiler/damlc/tests:platform-independence-dar-hash-file-matches. It should be enough to update its hash in bazel-bin/compiler/damlc/tests/platform-independence-generated.dar-hash:

  b98e0e49d6d29d2305b0fd26b61e65ffb88d0c2a79bf10136a8d0c026b32d9bc  META-INF/MANIFEST.MF
- b5c40ce08e30cf16a8cad16e2341d01d6ee49984fb8670cd12d7bea4984fae91  platform-independence-1.0.0-1ad54d1bc41e9d075a7b1ea15ac8a0f1764cf679b012077fa52a7d8335b21c3b/compiler/damlc/tests/PlatformIndependence.daml
+ af53bfb744c41db01eb8066a4f2485bab8af7444206202213be5a37dc0e2f36d  platform-independence-1.0.0-1ad54d1bc41e9d075a7b1ea15ac8a0f1764cf679b012077fa52a7d8335b21c3b/compiler/damlc/tests/PlatformIndependence.daml
  1f6ea91c9e829136d47bf8cd7a7ae0c61bde6036b2d5b4a85d24fd3e391e6891  platform-independence-1.0.0-1ad54d1bc41e9d075a7b1ea15ac8a0f1764cf679b012077fa52a7d8335b21c3b/daml-prim-886ba455abe8d308948a79e9d63bce1c55f1a1f6a28099c7f384a8ba123bd642.dalf

the same change should apply to #18169

garyverhaegen-da added a commit that referenced this pull request Jan 15, 2024
garyverhaegen-da added a commit that referenced this pull request Jan 15, 2024
* update copyright (infra)

* get CI to pass, will undo in #18167
Copy link

@marciw-da marciw-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@garyverhaegen-da garyverhaegen-da merged commit 179d853 into main Jan 15, 2024
16 checks passed
@garyverhaegen-da garyverhaegen-da deleted the update-copyright branch January 15, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants