Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fabric, corda, aurora to daml integration kit roadmap #1813

Merged
merged 2 commits into from
Jun 21, 2019

Conversation

dasormeter
Copy link
Collaborator

@dasormeter dasormeter commented Jun 21, 2019

  • Update DAML Integration Kit roadmap to include Hyperledger Fabric, Corda and Aurora
  • Corrected links for Canton
  • Small wording and formatting changes

Pull Request Checklist

Copy link
Contributor

@bethaitman bethaitman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just about to go on holiday so I don't want to block you from merging this in.

I've made some suggestions that I think would make this a little clearer - I think the new heading titles in the table are a little confusing - but I think the most important thing is to publish this so we have the information live.

:header-rows: 1

* - Ledger
- Status
- Developer
- More
- Integration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess is that this should be

Suggested change
- Integration
- Integration Developer

- Developer
- More
- Integration
- Deployment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And my understanding is that this should be

Suggested change
- Deployment
- Deployment Platform

* - :doc:`/tools/sandbox`
- Stable
- `Digital Asset <https://digitalasset.com/>`__
- TBD
- `PostgreSQL <https://www.postgresql.org/>`__ backend coming soon
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually done, right? We could link to https://docs.daml.com/tools/sandbox.html#running-with-persistence.

@mergify mergify bot merged commit 4eb7373 into master Jun 21, 2019
@mergify mergify bot deleted the update-integration-list branch June 21, 2019 21:00
@bethaitman
Copy link
Contributor

Oops, I didn't realise that that had the automerge tag on, I guess I shouldn't have approved.

If you could address the comments in a follow-up PR that'd be great!

@dasormeter
Copy link
Collaborator Author

@bethaitman -- yup will do right now in followup pr

@dasormeter
Copy link
Collaborator Author

follow-on PR addressing comments : #1817

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants