Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept a run-all-tests commit trailer #17989

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Accept a run-all-tests commit trailer #17989

merged 2 commits into from
Dec 6, 2023

Conversation

paulbrauner-da
Copy link
Contributor

@paulbrauner-da paulbrauner-da commented Dec 6, 2023 •
edited
Loading

After #17956, the CI only run a subset of tests against PRs, and all tests against main after merging. This PR introduces a way to force all tests to run against a PR, by adding a run-all-tests: true trailer to the commit message.

I tested it on the 3 platforms with and without the trailer.

@paulbrauner-da paulbrauner-da force-pushed the pb/run-all-tests-trailer branch 3 times, most recently from 7f07cf7 to c3b7323 Compare December 6, 2023 14:01
@paulbrauner-da paulbrauner-da force-pushed the pb/run-all-tests-trailer branch from c3b7323 to f089620 Compare December 6, 2023 14:34
@paulbrauner-da paulbrauner-da marked this pull request as ready for review December 6, 2023 14:51
garyverhaegen-da
garyverhaegen-da reviewed Dec 6, 2023
View reviewed changes
build.sh Outdated Show resolved Hide resolved
garyverhaegen-da
garyverhaegen-da reviewed Dec 6, 2023
View reviewed changes
build.sh Outdated Show resolved Hide resolved
garyverhaegen-da
garyverhaegen-da approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@garyverhaegen-da garyverhaegen-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paulbrauner-da paulbrauner-da force-pushed the pb/run-all-tests-trailer branch from b9296db to 5cafd8d Compare December 6, 2023 15:13
@paulbrauner-da paulbrauner-da enabled auto-merge (squash) December 6, 2023 15:14
@paulbrauner-da paulbrauner-da merged commit 4d0ecd7 into main Dec 6, 2023
18 checks passed
@paulbrauner-da paulbrauner-da deleted the pb/run-all-tests-trailer branch December 6, 2023 15:36
@raphael-speyer-da raphael-speyer-da mentioned this pull request Dec 7, 2023
Merged
raphael-speyer-da added a commit that referenced this pull request Dec 8, 2023
@raphael-speyer-da
precommit: add check for modified files under packages with `main-onl…
51bf3da 
…y` targets. (#17993)

Since #17989

A simple heuristic to remind you to consider adding `run-all-tests: true` to your commit message if making changes in corners of the codebase most likely affected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyverhaegen-da garyverhaegen-da garyverhaegen-da approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulbrauner-da @garyverhaegen-da