Switch from Akka to Pekko #17814

nmarton-da · 2023-11-13T12:47:13Z

The changes in the first commit are genereted by the following script file:

#!/bin/bash

function rename_file_with_akka() {
  SRC="$1"
  DST=$(echo "$SRC" | sed -e 's/Akka/Pekko/g')
  if [ -f $SRC ];
  then
    echo from $SRC
    echo "to  " $DST
    git mv "$SRC" "$DST"
  fi
}
export -f rename_file_with_akka

# rename files with Akka to Pekko
find . \
  -type f \
  -name "*Akka*" \
  \! -path "./bazel-bin*" \
  \! -path "./bazel-daml*" \
  \! -path "./bazel-out*" \
  \! -path "./bazel-testlogs*" \
  \! -path "./.*" \
  \! -path "*maven_install*" \
  \! -path "./pekko-rename.sh" \
  \! -path "./NOTICES" \
  \! -path "./bazel-java-deps.bzl" \
  -exec bash -c 'rename_file_with_akka "$0"' {} \;

function rename_dir_with_akka() {
  SRC="$1"
  DST=$(echo "$SRC" | sed -e 's/\(.*\)akka/\1pekko/')
  if [ -d $SRC ];
  then
    echo from $SRC
    echo "to  " $DST
    git mv "$SRC" "$DST"
  fi
}
export -f rename_dir_with_akka

# rename dirs with akka to pekko
find . \
  -depth \
  -type d \
  -name "*akka*" \
  \! -path "./bazel-bin*" \
  \! -path "./bazel-daml*" \
  \! -path "./bazel-out*" \
  \! -path "./bazel-testlogs*" \
  \! -path "./.*" \
  \! -path "*maven_install*" \
  \! -path "./pekko-rename.sh" \
  \! -path "./NOTICES" \
  \! -path "./bazel-java-deps.bzl" \
  -exec bash -c 'rename_dir_with_akka "$0"' {} \;

# rename imports
find . \
  -type f \
  -name "*.scala" \
  \! -path "./bazel-bin*" \
  \! -path "./bazel-daml*" \
  \! -path "./bazel-out*" \
  \! -path "./bazel-testlogs*" \
  \! -path "./.*" \
  \! -path "*maven_install*" \
  \! -path "./pekko-rename.sh" \
  \! -path "./NOTICES" \
  \! -path "./bazel-java-deps.bzl" \
  -print0 | \
  xargs -0 sed -i 's/import\sakka/import org\.apache\.pekko/g'

# rename bazel dependency references
find . \
  -type f \
  \! -path "./bazel-bin*" \
  \! -path "./bazel-daml*" \
  \! -path "./bazel-out*" \
  \! -path "./bazel-testlogs*" \
  \! -path "./.*" \
  \! -path "*maven_install*" \
  \! -path "./pekko-rename.sh" \
  \! -path "./NOTICES" \
  \! -path "./bazel-java-deps.bzl" \
  -print0 | \
  xargs -0 sed -i 's/com_typesafe_akka/org_apache_pekko/g'

# rename akka slf4j logger
find . \
  -type f \
  \! -path "./bazel-bin*" \
  \! -path "./bazel-daml*" \
  \! -path "./bazel-out*" \
  \! -path "./bazel-testlogs*" \
  \! -path "./.*" \
  \! -path "*maven_install*" \
  \! -path "./pekko-rename.sh" \
  \! -path "./NOTICES" \
  \! -path "./bazel-java-deps.bzl" \
  -print0 | \
  xargs -0 sed -i 's/akka\.event\.slf4j\.Slf4jLogger/org\.apache\.pekko\.event\.slf4j\.Slf4jLogger/g'

# rename akka materializer logger
find . \
  -type f \
  \! -path "./bazel-bin*" \
  \! -path "./bazel-daml*" \
  \! -path "./bazel-out*" \
  \! -path "./bazel-testlogs*" \
  \! -path "./.*" \
  \! -path "*maven_install*" \
  \! -path "./pekko-rename.sh" \
  \! -path "./NOTICES" \
  \! -path "./bazel-java-deps.bzl" \
  -print0 | \
  xargs -0 sed -i 's/akka\.stream\.Materializer/org\.apache\.pekko\.stream\.Materializer/g'

# rename akka TestEventListener logger
find . \
  -type f \
  \! -path "./bazel-bin*" \
  \! -path "./bazel-daml*" \
  \! -path "./bazel-out*" \
  \! -path "./bazel-testlogs*" \
  \! -path "./.*" \
  \! -path "*maven_install*" \
  \! -path "./pekko-rename.sh" \
  \! -path "./NOTICES" \
  \! -path "./bazel-java-deps.bzl" \
  -print0 | \
  xargs -0 sed -i 's/akka\.testkit\.TestEventListener/org\.apache\.pekko\.testkit\.TestEventListener/g'

# rename all akka
find . \
  -type f \
  \! -path "./bazel-bin*" \
  \! -path "./bazel-daml*" \
  \! -path "./bazel-out*" \
  \! -path "./bazel-testlogs*" \
  \! -path "./.*" \
  \! -path "*maven_install*" \
  \! -path "./pekko-rename.sh" \
  \! -path "./NOTICES" \
  \! -path "./bazel-java-deps.bzl" \
  -print0 | \
  xargs -0 sed -i 's/akka/pekko/g'

# rename all Akka
find . \
  -type f \
  \! -path "./bazel-bin*" \
  \! -path "./bazel-daml*" \
  \! -path "./bazel-out*" \
  \! -path "./bazel-testlogs*" \
  \! -path "./.*" \
  \! -path "*maven_install*" \
  \! -path "./pekko-rename.sh" \
  \! -path "./NOTICES" \
  \! -path "./bazel-java-deps.bzl" \
  -print0 | \
  xargs -0 sed -i 's/Akka/Pekko/g'

Changes in the second commit, are manual changes:

adapt fully qualified name references
adapt pekko package declarations
adapt bazel files with dependency changes
adapt canton pekko lib shade_rule
adapt logger configuration declarations
pin maven dependencies
revert incorrect changes by script to compatibility module
Workarounds for further TODOs:
** disable http-json-perf and libs-scala/gatling-utils modules to maintain clean pekko dependencies (without akka)
** disable GraphQLSchemaSpec test (sangria library needs to be upgraded)

nmarton-da · 2023-11-13T13:52:13Z

...or/backend/src/test/scala/com/digitalasset/navigator/backend/graphql/GraphQLSchemaSpec.scala

@@ -12,7 +12,8 @@ import sangria.schema.Schema
 import scala.io.Source

 class GraphQLSchemaSpec extends AnyWordSpec with Matchers {
-  "The rendered schema" should {
+  // TODO GraphQL sangria needs to be upgrade from 2.x.x to 3.x.x due to fatally colliding parboiled dependency (pekko bumps parboiled to 2.5, causing NoSuchMethodError in this test)
+  "The rendered schema" ignore {


@remyhaemmerle-da @raphael-speyer-da This test is failing due to library dependency discrepancies:

we are on 2.0.1 which has a praboiled 2.1.8 dependecy

pekko pulls in parboiled 2.5.0

this was not working, GraphQLSchemaSpec was failing

I tried 2.1.6 (parboiled dependency on 2.3.0) -- without success

IMHO we should bump at least to 4.0.0, which is the first version with parboiled 2.5.0 dep

we could still live for a while with just disabling this test, but we need a solution for the release

nmarton-da · 2023-11-13T13:55:04Z

libs-scala/gatling-utils/BUILD.bazel_disabled

@remyhaemmerle-da @raphael-speyer-da please note I temporarily disabled this and the //ledger-service/http-json-perf modules so we do not have akka dependencies.
Never the less this might be possible. We need subsequent PRs enabling this again, before releasing

nmarton-da · 2023-11-13T13:57:18Z

canton/community/lib/README.md

@@ -1,6 +1,6 @@
 Forked or extended Daml and third-party libraries:

- [akka](https://github.com/akka/akka/) - Forked some files for adding more debug logging
+- [pekko](https://github.com/pekko/pekko/) - Forked some files for adding more debug logging


@andreaslochbihler-da @remyhaemmerle-da
This file and the pekko/LICENCE file was only changed by my migration script.
Is this sufficient for now? (as before releasing we anyway need the proper fix for the source of these canton files, which needs to be propagated anyway to daml again)?

https://github.com/pekko/pekko/ gives me a 404. You want to change this to https://github.com/apache/incubator-pekko, but given that this file originates from the Canton repo, I'd say that you want to change it there and not care about the files in here. This is temporary anyway until the Canton repo has been updated.

@remyhaemmerle-da Do you agree?

this is part of the drop, so I do not care.

It will be overwrite by the next code prod.

mziolekda · 2023-11-13T15:27:06Z

compatibility/WORKSPACE

@@ -345,7 +345,7 @@ load("@scala_version//:index.bzl", "scala_artifacts", "scala_major_version", "sc
 maven_install(
    name = "maven",
    artifacts = [
-        "com.daml:bindings-pekko_2.13:{}".format(latest_stable_version),
+        "com.daml:bindings-akka_2.13:{}".format(latest_stable_version),


Is this correct?

I'll answer myself: yes it is, as I have noticed this on the PR synopsis

revert incorrect changes by script to compatibility module

mziolekda

Thanks to splitting the PR into series of digestable commits, it has become quite reviewable
LGTM!

remyhaemmerle-da

Thanks.

This commit is exclusively contains changes by the bash script. For the bash script is present at the pull request.

* adapt fully qualified name references * adapt pekko package declarations * adapt bazel files with dependency changes * adapt canton pekko lib shade_rule * adapt logger configuration declarations * pin maven dependencies * revert incorrect changes by script to compatibility module Workarounds for further TODOs: * disable http-json-perf and libs-scala/gatling-utils modules to maintain clean pekko dependencies (without akka) * disable GraphQLSchemaSpec test (sangria library needs to be upgraded)

nmarton-da changed the title ~~Nmarton/switch from akka to pekko~~ Switch from Akka to Pekko Nov 13, 2023

nmarton-da commented Nov 13, 2023

View reviewed changes

nmarton-da marked this pull request as ready for review November 13, 2023 14:16

nmarton-da requested review from a team, remyhaemmerle-da, filmackay, garyverhaegen-da, basvangijzel-DA, akrmn, dylant-da, samuel-williams-da and paulbrauner-da as code owners November 13, 2023 14:16

mziolekda reviewed Nov 13, 2023

View reviewed changes

mziolekda approved these changes Nov 13, 2023

View reviewed changes

remyhaemmerle-da approved these changes Nov 13, 2023

View reviewed changes

nmarton-da added 3 commits November 13, 2023 19:42

Automated renames by bash script

cb53069

This commit is exclusively contains changes by the bash script. For the bash script is present at the pull request.

Formatting

41e5478

nmarton-da force-pushed the nmarton/switch-from-akka-to-pekko branch from dc821c1 to 41e5478 Compare November 13, 2023 18:44

mziolekda enabled auto-merge (squash) November 13, 2023 22:20

mziolekda merged commit 6933514 into main Nov 13, 2023
17 checks passed

mziolekda deleted the nmarton/switch-from-akka-to-pekko branch November 13, 2023 23:22

remyhaemmerle-da restored the nmarton/switch-from-akka-to-pekko branch November 14, 2023 08:17

remyhaemmerle-da deleted the nmarton/switch-from-akka-to-pekko branch November 14, 2023 08:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch from Akka to Pekko #17814

Switch from Akka to Pekko #17814

nmarton-da commented Nov 13, 2023 •

edited by mziolekda

Loading

nmarton-da Nov 13, 2023

nmarton-da Nov 13, 2023

nmarton-da Nov 13, 2023

andreaslochbihler-da Nov 13, 2023

remyhaemmerle-da Nov 13, 2023

remyhaemmerle-da Nov 13, 2023

nmarton-da Nov 13, 2023

mziolekda Nov 13, 2023

mziolekda Nov 13, 2023

mziolekda left a comment

remyhaemmerle-da left a comment

Switch from Akka to Pekko #17814

Switch from Akka to Pekko #17814

Conversation

nmarton-da commented Nov 13, 2023 • edited by mziolekda Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mziolekda left a comment

Choose a reason for hiding this comment

remyhaemmerle-da left a comment

Choose a reason for hiding this comment

nmarton-da commented Nov 13, 2023 •

edited by mziolekda

Loading