Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade protobuf #1781

Merged
merged 2 commits into from
Jun 20, 2019
Merged

Upgrade protobuf #1781

merged 2 commits into from
Jun 20, 2019

Conversation

cocreature
Copy link
Contributor

This fixes the annoying “illegal reflective access” warnings when
using a newer JDK.

Pull Request Checklist

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@cocreature cocreature requested a review from hurryabit June 20, 2019 11:15
hurryabit
hurryabit approved these changes Jun 20, 2019
View reviewed changes
Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks.

@hurryabit hurryabit requested review from bitonic and gerolf-da June 20, 2019 11:27
gerolf-da
gerolf-da requested changes Jun 20, 2019
View reviewed changes
Copy link
Contributor

@gerolf-da gerolf-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some SDK artefacts (e.g. java bindings) for which this is a change in the pom file. Please add release notes for that.

@cocreature
Copy link
Contributor Author

@gerolf-da Good catch, I added it to the release notes.

@cocreature
Upgrade protobuf
49f2c27 
This fixes the annoying “illegal reflective access” warnings when
using a newer JDK.
@cocreature
Add release notes
48e9b6d
@mergify mergify bot merged commit 8272f95 into master Jun 20, 2019
@mergify mergify bot deleted the upgrade-protobuf branch June 20, 2019 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerolf-da gerolf-da gerolf-da approved these changes

@hurryabit hurryabit hurryabit approved these changes

@bitonic bitonic Awaiting requested review from bitonic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cocreature @hurryabit @gerolf-da