Add test-daml-version-and-install script, fix more updating issues #17599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylant-da
requested review from
remyhaemmerle-da,
filmackay,
basvangijzel-DA,
garyverhaegen-da and
gerolf-da
as code owners
dylant-da
force-pushed
the
fix-version-caching
branch
from
2083cbd to
7aaf8b1
Compare
run-full-compat: true
dylant-da
force-pushed
the
fix-version-caching
branch
from
7aaf8b1 to
c3459e6
Compare
run-full-compat: true
run-full-compat: true
dylant-da
force-pushed
the
fix-version-caching
branch
from
36dcb1e to
6314e21
Compare
run-full-compat: true
dylant-da
force-pushed
the
fix-version-caching
branch
from
1289021 to
bd4e527
Compare
dylant-da
force-pushed
the
fix-version-caching
branch
from
6651bc3 to
7ad0a29
Compare
run-full-compat: true
dylant-da
force-pushed
the
fix-version-caching
branch
from
7ad0a29 to
381d6b5
Compare
run-full-compat: true
dylant-da
force-pushed
the
fix-version-caching
branch
from
9aa7e9d to
6cc9ead
Compare
dylant-da
added a commit
that referenced
this pull request
Oct 31, 2023
…17599) * Add test-daml-version-and-install script, fix more updating issues * Test `daml install`, improve checks for snapshots.txt run-full-compat: true * bring diff into scope for test-daml-version-and-install.sh * Use runfiles to locate daml in test-daml-version-and-install.sh * Bound versions.is_at_least("2.7.5") for test-daml-version-and-install.sh run-full-compat: true * Add logged diffing to diagnose issue run-full-compat: true * Add diff to data of test-daml-version-and-install.sh run-full-compat: true * Fix `daml install` call breaking - cache should still be refreshed * Address minor issues: Daml 10.x.y matching, quoting, wrong comment run-full-compat: true * Drop printing * Improve logging for test-daml-version-and-install.sh * Fix undercased variable name DAML_CACHE, rerun CI run-full-compat: true * disable on windows run-full-compat: true
dylant-da
added a commit
that referenced
this pull request
Nov 23, 2023
…17599) * Add test-daml-version-and-install script, fix more updating issues * Test `daml install`, improve checks for snapshots.txt run-full-compat: true * bring diff into scope for test-daml-version-and-install.sh * Use runfiles to locate daml in test-daml-version-and-install.sh * Bound versions.is_at_least("2.7.5") for test-daml-version-and-install.sh run-full-compat: true * Add logged diffing to diagnose issue run-full-compat: true * Add diff to data of test-daml-version-and-install.sh run-full-compat: true * Fix `daml install` call breaking - cache should still be refreshed * Address minor issues: Daml 10.x.y matching, quoting, wrong comment run-full-compat: true * Drop printing * Improve logging for test-daml-version-and-install.sh * Fix undercased variable name DAML_CACHE, rerun CI run-full-compat: true * disable on windows run-full-compat: true
dylant-da
added a commit
that referenced
this pull request
Nov 24, 2023
…17599) * Add test-daml-version-and-install script, fix more updating issues * Test `daml install`, improve checks for snapshots.txt run-full-compat: true * bring diff into scope for test-daml-version-and-install.sh * Use runfiles to locate daml in test-daml-version-and-install.sh * Bound versions.is_at_least("2.7.5") for test-daml-version-and-install.sh run-full-compat: true * Add logged diffing to diagnose issue run-full-compat: true * Add diff to data of test-daml-version-and-install.sh run-full-compat: true * Fix `daml install` call breaking - cache should still be refreshed * Address minor issues: Daml 10.x.y matching, quoting, wrong comment run-full-compat: true * Drop printing * Improve logging for test-daml-version-and-install.sh * Fix undercased variable name DAML_CACHE, rerun CI run-full-compat: true * disable on windows run-full-compat: true
garyverhaegen-da
pushed a commit
that referenced
this pull request
Nov 29, 2023
* Fix version caching (#17581) * Make at least one call API if there is no cache * document why we don't use /repos/{owner}/{repo}/releases/latest * Refactoring * Improve name - envLatestStableSdkVersion is only used in one location * `daml install latest` overrides update-check in daml-config.yaml * Improve comments for cacheAvailableSdkVersions * lint * Drop lookup for UpdateCheckNever https://dev.azure.com/digitalasset/daml/_build/results?buildId=151669&view=logs&jobId=870bb40c-6da0-5bff-67ed-547f10fa97f2&j=870bb40c-6da0-5bff-67ed-547f10fa97f2&t=fdc575a5-c2b4-5f52-8465-2c7aa3e12574 reports daml: Snapshot versions list from https://api.github.com/repos/digital-asset/daml/releases does not contain valid JSON context: Fetching list of available SDK versions details: Error in $: expected Array, but encountered Object I assume this is because the request returned some sort of failure * Add test-daml-version-and-install script, fix more updating issues (#17599) * Add test-daml-version-and-install script, fix more updating issues * Test `daml install`, improve checks for snapshots.txt run-full-compat: true * bring diff into scope for test-daml-version-and-install.sh * Use runfiles to locate daml in test-daml-version-and-install.sh * Bound versions.is_at_least("2.7.5") for test-daml-version-and-install.sh run-full-compat: true * Add logged diffing to diagnose issue run-full-compat: true * Add diff to data of test-daml-version-and-install.sh run-full-compat: true * Fix `daml install` call breaking - cache should still be refreshed * Address minor issues: Daml 10.x.y matching, quoting, wrong comment run-full-compat: true * Drop printing * Improve logging for test-daml-version-and-install.sh * Fix undercased variable name DAML_CACHE, rerun CI run-full-compat: true * disable on windows run-full-compat: true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
daml versionanddaml installviatest-daml-version-and-install