Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update daml-assistant to support new versioning #17553

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

samuel-williams-da
Copy link
Contributor

@samuel-williams-da samuel-williams-da commented Oct 11, 2023

Since ~2.8.snapshot, the version of the daml sdk can differ from the version of the release (sometimes called the enterprise release)
As such, the path to the sdk is no longer releases/tags/v$VERSION/daml-sdk-$VERSION-$OS.tar.gz, but instead
releases/tags/v$RELEASE_VERSION/daml-sdk-$SDK_VERSION-$OS.tar.gz

We still work with release versions via the assistant, so now we discover the sdk version by listing the files in the release and searching for the daml-sdk linux tarfile.

Related to: https://github.com/digital-asset/daml/pull/17550/files
Verified working via both github and artifactory.

@samuel-williams-da samuel-williams-da force-pushed the sw/daml-assistant-handle-new-versioning branch from 987b116 to 21fe6a6 Compare October 11, 2023 16:09
Copy link
Collaborator

@remyhaemmerle-da remyhaemmerle-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@garyverhaegen-da garyverhaegen-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@samuel-williams-da samuel-williams-da merged commit 03bb8bf into main Oct 12, 2023
@samuel-williams-da samuel-williams-da deleted the sw/daml-assistant-handle-new-versioning branch October 12, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants