Defining first endpoints for ledger-service/http-json #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leo-da
force-pushed
the
leo-1628-transaction-tree-json-encoding-2
branch
2 times, most recently
from
fa87603 to
b89c60b
Compare
leo-da
force-pushed
the
leo-1628-transaction-tree-json-encoding-2
branch
from
d2f0c9f to
17a23dd
Compare
…n-tree-json-encoding-2
…ncoding-2' into leo-1628-transaction-tree-json-encoding-2 # Conflicts: # ledger-service/http-json/src/main/scala/com/digitalasset/http/PackageService.scala
…n-tree-json-encoding-2
…n-tree-json-encoding-2
…n-tree-json-encoding-2
…n-tree-json-encoding-2
…n-tree-json-encoding-2
…n-tree-json-encoding-2
using domain.TemplateId[Unit] and domain.TemplateId[String]
…n-tree-json-encoding-2
…n-tree-json-encoding-2
S11001001
changed the title
…ncoding-2' into leo-1628-transaction-tree-json-encoding-2
…n-tree-json-encoding-2
S11001001
approved these changes
Jul 3, 2019
|
The reason I want to merge it, some extractor logic has been refactored, LedgerReader has been moved into a separate module. Had to resolve some master merge conflicts around LedgerReader |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.