debug cache #17377
Merged
debug cache #17377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyverhaegen-da
force-pushed
the
debug-cache
branch
from
54db39a to
4c2355c
Compare
garyverhaegen-da
force-pushed
the
debug-cache
branch
from
1cc56c0 to
fdd8a91
Compare
garyverhaegen-da
commented
Sep 8, 2023
| @@ -83,5 +82,4 @@ if ($env:SKIP_TESTS -ceq "False") { | |||
| `-`-experimental_profile_include_target_label ` | |||
| `-`-build_event_json_file test-events.json ` | |||
| `-`-build_event_publish_all_actions ` | |||
| `-`-experimental_execution_log_file ${ARTIFACT_DIRS}/logs/test_execution_windows_$env:SYSTEM_JOBATTEMPT.log ` | |||
There was a problem hiding this comment.
The binary execution log is basically useless: as far as I know nobody ever looks at it, and I don't seem to be able to build the parser for it. Trying to get the JSON execution log crashes the build on an OOM.
garyverhaegen-da
commented
Sep 8, 2023
| condition: and(succeededOrFailed(), | ||
| or(eq(${{parameters.is_release}}, 'false'), | ||
| ne('${{parameters.name}}', 'm1'))) | ||
|
|
There was a problem hiding this comment.
JSON execution logs are created pre-gzipped by Bazel, so there's little benefit to re-gzipping them.
garyverhaegen-da
commented
Sep 8, 2023
| "rev": "3a86856a13c88c8c64ea32082a851fefc79aa700", | ||
| "sha256": "04dd4g24061p8sw922zjickahqwn3wa9l3j5qllfzp5n6dy9is16" | ||
| "rev": "9a82a9b5248919805a2400266ebd881d5783df2a", | ||
| "sha256": "142x1zq3cjadgmvfv0paydlq268pfinllqpq2vl0vxwdiq2nr9iz" |
There was a problem hiding this comment.
This is the heart of this change: it looks like Bazel 5.2.0 is simply broken, so I'm bumping to 5.3.2.
garyverhaegen-da
requested review from
filmackay,
basvangijzel-DA,
remyhaemmerle-da,
akrmn,
dylant-da,
samuel-williams-da,
paulbrauner-da and
gerolf-da
as code owners
akrmn
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.