bump canton + fix bouncycastle #17228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remyhaemmerle-da
requested review from
garyverhaegen-da and
rgugliel-da
as code owners
remyhaemmerle-da
requested review from
nickchapman-da,
basvangijzel-DA,
akrmn,
dylant-da and
samuel-williams-da
as code owners
thibault-da
reviewed
Aug 4, 2023
| @@ -17,6 +17,7 @@ java_binary( | |||
| runtime_deps = [ | |||
| # Do not sort | |||
| "//canton:lib", | |||
| "@maven//:org_bouncycastle_bcprov_jdk15on", | |||
There was a problem hiding this comment.
do you need this even though the bcprov jar is in canton/lib ? The risk here is that if we update the version in canton we forget to update it here and get mismatching runtime versions ?
There was a problem hiding this comment.
We can try to do something clever in main, for 2.7.x this seems acceptable for me.
thibault-da
approved these changes
Aug 4, 2023
carlpulley-da
approved these changes
Aug 4, 2023
remyhaemmerle-da
added a commit
that referenced
this pull request
Aug 4, 2023
remyhaemmerle-da
added a commit
that referenced
this pull request
Aug 4, 2023
* Rename UserError and DevError * activate DeeplyNestedValueIT (disable in #17228) --------- Co-authored-by: Remy Haemmerle <Remy.Haemmerle@daml.com>
garyverhaegen-da
added a commit
that referenced
this pull request
Aug 5, 2023
remyhaemmerle-da
added a commit
that referenced
this pull request
Aug 18, 2023
This reverts commit 4dee553.
remyhaemmerle-da
added a commit
that referenced
this pull request
Aug 21, 2023
This reverts commit 4dee553 and bump canton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle breaking change from https://github.com/DACH-NY/canton/pull/14131