JSON API: add PruningTest and make it pass #17167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphael-speyer-da
requested review from
filmackay,
garyverhaegen-da,
remyhaemmerle-da and
rgugliel-da
as code owners
raphael-speyer-da
force-pushed
the
json-api-lt-17-rls-on-pruning-error-clear-cache-and-retry
branch
from
260792e to
f25ce06
Compare
raphael-speyer-da
requested review from
basvangijzel-DA and
gerolf-da
as code owners
raphael-speyer-da
force-pushed
the
json-api-lt-17-rls-on-pruning-error-clear-cache-and-retry
branch
4 times, most recently
from
23a15cb to
26f684e
Compare
raphael-speyer-da
force-pushed
the
json-api-lt-17-rls-on-pruning-error-clear-cache-and-retry
branch
from
26f684e to
88d83c9
Compare
remyhaemmerle-da
approved these changes
Jul 25, 2023
|
|
||
| Those tests are run on CI. | ||
|
|
||
| If you're using a local build of canton (setting `local` to `True` per above) | ||
| _and_ you are explicitly overwriting the `*_tag_filters` to run the Canton EE | ||
| _and_ you are explicitly using `--config=canton-ee` to run the Canton EE |
canton_dep.bzl
Outdated
| @@ -4,5 +4,5 @@ | |||
| canton = { | |||
| "sha": "fa0257b6b6d6673934db535216a861552ed57017481581b4f190742d13a5842e", | |||
| "url": "https://www.canton.io/releases/canton-open-source-2.7.0-snapshot.20230719.10832.0.v93eda8bc.tar.gz", | |||
| "local": True, | |||
| "local": False, | |||
raphael-speyer-da
deleted the
json-api-lt-17-rls-on-pruning-error-clear-cache-and-retry
branch
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the ledger has been pruned more recently that the last cached copy, then attempting to fetch the changes since that last offset will fail, rendering the relevant template(s) unqueryable. This PR detects that condition, clears the cache for the relevant template and queries again, which will refresh the cache with a fresh copy of the ACS for that template, and serve the query from that.
I also made some usability tweaks around running canton-ee tests, to help improve the dev experience for failures I came across while trying to run them. Specifically
--config=canton-eeto opt into the tests which require canton-ee