Add placeholder flag for contract upgrading #17126
Conversation
| @@ -20,8 +20,6 @@ import scala.language.implicitConversions | |||
|
|
|||
| class ConfigSpec extends AsyncWordSpec with Matchers with CantonFixture { | |||
|
|
|||
| final override protected lazy val devMode: Boolean = true | |||
There was a problem hiding this comment.
Can someone explain this for me please.
There was a problem hiding this comment.
Setting devMode to be true means Canton logging will be kept.
There was a problem hiding this comment.
Ah, not quite correct (I think it used to be?). devMode now means our patched version of Canton is used.
There was a problem hiding this comment.
devMode now means our patched version of Canton is used.
@carlpulley-da you are confusing with cantonFixtureDebugMode
devMode = true always meant our patched version of Canton is used (+ canton is started in dev mode).
Such tests that use the patched version of Canton need be mark with the tag dev-canton-test in the bazel Build file which was not the case of this ConfigTest.
Taking into account ConfigTest test does not seems to used any dev feature, it seems more natural to remove the devMode = true that to mark it with dev-canton-test
|
Woo Hoo. Finally! |
|
Once canton has been compiled against this version we can re-enable the tests. |
Related canton PR: https://github.com/DACH-NY/canton/pull/13971