Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-env/windows: pin nsis #17002

Merged
merged 1 commit into from
Jun 16, 2023
Merged

dev-env/windows: pin nsis #17002

merged 1 commit into from
Jun 16, 2023

Conversation

garyverhaegen-da
Copy link
Contributor

I've seen a handful of failures of the form:

>> Installing 'nsis-3.04' ...
<< Unknown state:
Installing 'nsis-3.04' (3.04) [64bit]
The request was aborted: Could not create SSL/TLS secure channel.
URL https://downloads.sourceforge.net/project/nsis/NSIS%203/3.04/nsis-3.04.zip is not valid

<< Unknown state:
Installing 'nsis-3.04' (3.04) [64bit]
The request was aborted: Could not create SSL/TLS secure channel.
URL https://downloads.sourceforge.net/project/nsis/NSIS%203/3.04/nsis-3.04.zip is not valid
At D:\a\3\s\dev-env\windows\libexec\core.ps1:159 char:13
+             throw $msg
+             ~~~~~~~~~~
    + CategoryInfo          : OperationStopped: (<< Unknown stat...s not valid
:String) [], RuntimeException
    + FullyQualifiedErrorId : << Unknown state:
Installing 'nsis-3.04' (3.04) [64bit]
The request was aborted: Could not create SSL/TLS secure channel.
URL https://downloads.sourceforge.net/project/nsis/NSIS%203/3.04/nsis-3.04.zip is not valid

on CI recently. Hopefully this will fix it. As usual, you can check that the file is the same because the hash has not changed.

I've seen a handful of failures of the form:

```
>> Installing 'nsis-3.04' ...
<< Unknown state:
Installing 'nsis-3.04' (3.04) [64bit]
The request was aborted: Could not create SSL/TLS secure channel.
URL https://downloads.sourceforge.net/project/nsis/NSIS%203/3.04/nsis-3.04.zip is not valid

<< Unknown state:
Installing 'nsis-3.04' (3.04) [64bit]
The request was aborted: Could not create SSL/TLS secure channel.
URL https://downloads.sourceforge.net/project/nsis/NSIS%203/3.04/nsis-3.04.zip is not valid
At D:\a\3\s\dev-env\windows\libexec\core.ps1:159 char:13
+             throw $msg
+             ~~~~~~~~~~
    + CategoryInfo          : OperationStopped: (<< Unknown stat...s not valid
:String) [], RuntimeException
    + FullyQualifiedErrorId : << Unknown state:
Installing 'nsis-3.04' (3.04) [64bit]
The request was aborted: Could not create SSL/TLS secure channel.
URL https://downloads.sourceforge.net/project/nsis/NSIS%203/3.04/nsis-3.04.zip is not valid
```

on CI recently. Hopefully this will fix it. As usual, you can check that
the file is the same because the hash has not changed.
Copy link
Contributor

@carlpulley-da carlpulley-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified SHA1 was ed241f7384f4e59d84b9a62c71d1f6955b6a719a - LGTM!

@garyverhaegen-da garyverhaegen-da enabled auto-merge (squash) June 16, 2023 09:54
@garyverhaegen-da garyverhaegen-da merged commit ef441d5 into main Jun 16, 2023
@garyverhaegen-da garyverhaegen-da deleted the pin-nsis-artifact branch June 16, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants