Fix up the CPP flags that are defined #1694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocreature
approved these changes
Jun 16, 2019
| "-D" ++ TARGET_OS ++ "_HOST_OS", | ||
| "-D" ++ TARGET_ARCH ++ "_HOST_ARCH" ] -} | ||
| let target_defs = | ||
| -- NEIL: Patched to use System.Info instead of constants from CPP |
There was a problem hiding this comment.
What exactly broke the existing code?
There was a problem hiding this comment.
Before I had commented out all these defines, when hacking over the CPP module in the first place. Shake has some #ifdef mingw32_HOST_OS and that wasn't defined, despite me being on Windows.
There was a problem hiding this comment.
Oooh, I missed the block comment around this. Now this makes a lot more sense :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required to load Shake with our repo, since that has platform-specific behaviour.