Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CatonFixture in its own bazel module #16824

Merged
merged 2 commits into from
May 10, 2023
Merged

Move CatonFixture in its own bazel module #16824

merged 2 commits into from
May 10, 2023

Conversation

remyhaemmerle-da
Copy link
Collaborator

No description provided.

@remyhaemmerle-da remyhaemmerle-da changed the title Move CatonFixtur in its own module Move CatonFixture in its own bazel module May 8, 2023
@remyhaemmerle-da remyhaemmerle-da marked this pull request as ready for review May 8, 2023 12:37
@remyhaemmerle-da remyhaemmerle-da requested review from a team and stefanobaghino-da May 8, 2023 12:38
samuel-williams-da
samuel-williams-da approved these changes May 9, 2023
View reviewed changes
daml-script/test/src/test-utils/com/daml/lf/engine/script/test/CompiledDar.scala
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now have this file twice in 2 places, should it maybe go somewhere else?

@stefanobaghino-da stefanobaghino-da removed their request for review May 10, 2023 10:39
@remyhaemmerle-da
Copy link
Collaborator Author

@samuel-williams-da @carlpulley-da This will conflict with you migration PRs.
Please take care to either:

  1. merge your PRs before this one
  2. rebase you PRs with main if you merge afrer this one.

In case of 1, please ping me once you merged.

@samuel-williams-da
Copy link
Contributor

I'm just waiting on a rereview from Stephen then I can merge mine

@samuel-williams-da
Copy link
Contributor

I'm happy to rebase though if you'd like to merge now, given i believe stephen is in NY

@carlpulley-da
Copy link
Contributor

carlpulley-da commented May 10, 2023 •
edited
Loading

Merged 16811, 16829, 16836 and 16837.

All that said, changes here look straightforward, so I'm happy to rebase once you merge this PR in.

@remyhaemmerle-da remyhaemmerle-da enabled auto-merge (squash) May 10, 2023 20:54
@remyhaemmerle-da
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@remyhaemmerle-da remyhaemmerle-da merged commit a863d69 into main May 10, 2023
@remyhaemmerle-da remyhaemmerle-da deleted the remy-it branch May 10, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuel-williams-da samuel-williams-da samuel-williams-da approved these changes

@carlpulley-da carlpulley-da carlpulley-da approved these changes

@filmackay filmackay Awaiting requested review from filmackay

@garyverhaegen-da garyverhaegen-da Awaiting requested review from garyverhaegen-da

@rgugliel-da rgugliel-da Awaiting requested review from rgugliel-da

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@remyhaemmerle-da @samuel-williams-da @carlpulley-da