Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GroupChat, take 2 #1671

Merged
merged 3 commits into from
Jun 17, 2019
Merged

GroupChat, take 2 #1671

merged 3 commits into from
Jun 17, 2019

Conversation

nickchapman-da
Copy link
Contributor

GroupChat, take 2

Following our extended discussion on slack yesterday about how to model a chat-room in DAML, and some of the issues this raises, I persevered with my own model, and then studied the models linked to by Bernhard and Ognjen.

In the end, my model looked rather similar to that of Ognjen's, whereas Bernhard's is quite a bit more complicated, I have a feeling this is because Bernhard is modelling additional features over and above the simple WhatsApp style functionality I have in mind. But we need to discuss more so I really understand.

This PR has the updated & simplified version of my GroupChat model, together with testing scenarios.
There is an extensive README which describes the Domain features being modelled, and discusses alternatives.

Pull Request Checklist

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦆

@nickchapman-da nickchapman-da merged commit 8cd1bc7 into master Jun 17, 2019
@nickchapman-da nickchapman-da deleted the group-chat-daml-model branch June 17, 2019 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant