Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GroupChat, take 2
Following our extended discussion on slack yesterday about how to model a chat-room in DAML, and some of the issues this raises, I persevered with my own model, and then studied the models linked to by Bernhard and Ognjen.
In the end, my model looked rather similar to that of Ognjen's, whereas Bernhard's is quite a bit more complicated, I have a feeling this is because Bernhard is modelling additional features over and above the simple WhatsApp style functionality I have in mind. But we need to discuss more so I really understand.
This PR has the updated & simplified version of my GroupChat model, together with testing scenarios.
There is an extensive README which describes the Domain features being modelled, and discusses alternatives.
Pull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines run
totrigger the build.