-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra: add a Windows node on Azure #16705
Conversation
421c635
to
931757f
Compare
931757f
to
7f7333d
Compare
The diff is a bit hard to follow (and larger than I'd like) so here are a few pointers to review it more effectively:
The omission of gcloud from dev-env places us in a bit of a bind: because the dev-env installation is part of the build, not the machine setup, we cannot run existing jobs on the new machines. But once this PR is merged, future builds will use the new dev-env definition and everything will be fine. So I think this PR should be merged as is and the removal of the GCP nodes should be done in a separate step. There are also a couple other things missing from this PR which will come later on:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.