Override engine and archive reader in canton jar used for testing #16667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remyhaemmerle-da
force-pushed
the
remy-lf-integration
branch
2 times, most recently
from
b8b58b1 to
0e5bf1c
Compare
remyhaemmerle-da
commented
Apr 6, 2023
daml-lf/integration-test/BUILD.bazel
Outdated
Comment on lines
52
to
62
| java_binary( | ||
| name = "canton-test", | ||
| main_class = "com.digitalasset.canton.CantonCommunityApp", | ||
| visibility = ["//visibility:public"], | ||
| runtime_deps = [ | ||
| # Do not sort | ||
| "//daml-lf/engine", | ||
| "//daml-lf/archive:daml_lf_archive_reader", | ||
| "@canton//:lib", | ||
| ], | ||
| ) |
There was a problem hiding this comment.
The crux of the PR is here !
There was a problem hiding this comment.
Yeah. Love this. Patch that jar!
| val cantonPath = rlocation( | ||
| "external/canton/lib/canton-open-source-2.7.0-SNAPSHOT.jar" | ||
| ) | ||
| val cantonPath = rlocation("daml-lf/integration-test:canton-test_deploy.jar") |
There was a problem hiding this comment.
Excellent! That saves me a job!!
remyhaemmerle-da
force-pushed
the
remy-lf-integration
branch
from
0e5bf1c to
306a6f9
Compare
carlpulley-da
approved these changes
Apr 6, 2023
remyhaemmerle-da
force-pushed
the
remy-lf-integration
branch
from
306a6f9 to
024e6fa
Compare
nickchapman-da
approved these changes
Apr 27, 2023
daml-lf/integration-test/BUILD.bazel
Outdated
Comment on lines
52
to
62
| java_binary( | ||
| name = "canton-test", | ||
| main_class = "com.digitalasset.canton.CantonCommunityApp", | ||
| visibility = ["//visibility:public"], | ||
| runtime_deps = [ | ||
| # Do not sort | ||
| "//daml-lf/engine", | ||
| "//daml-lf/archive:daml_lf_archive_reader", | ||
| "@canton//:lib", | ||
| ], | ||
| ) |
There was a problem hiding this comment.
Yeah. Love this. Patch that jar!
remyhaemmerle-da
force-pushed
the
remy-lf-integration
branch
from
024e6fa to
08bdb06
Compare
remyhaemmerle-da
requested review from
filmackay and
rgugliel-da
as code owners
remyhaemmerle-da
requested review from
nickchapman-da,
carlpulley-da and
a team
remyhaemmerle-da
force-pushed
the
remy-lf-integration
branch
from
08bdb06 to
9a5d6a4
Compare
nickchapman-da
approved these changes
May 2, 2023
| val cantonPath = rlocation( | ||
| "external/canton/lib/canton-open-source-2.7.0-SNAPSHOT.jar" | ||
| ) | ||
| val jarPath = if (devMode) cantonDevPath else cantonPath |
There was a problem hiding this comment.
I don't like that devMode gets into scope from import config._
But we can make a future PR to improve the clarity of this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR creates a jar for canton where LF libraries is overrides for testing LF Dev.
In this PR, we distinguish test using the "hacked" canton jar (using the bazel tag
canton-dev) from the one using the standard jar.Using infrastructure of #16765, we should be able to disable in case of breaking change in LF, and the automatically reenable those test canton have been updated with the change.