Customizable JWT audiences #16330
Merged
Customizable JWT audiences #16330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ae485a0.
skisel-da
changed the title
cocreature
reviewed
Feb 17, 2023
ledger-api/grpc-definitions/com/daml/ledger/api/v1/admin/identity_provider_config_service.proto
Outdated
Show resolved
Hide resolved
...local-store/src/test/lib/com/daml/platform/localstore/IdentityProviderConfigStoreTests.scala
Show resolved
Hide resolved
…ity_provider_config_service.proto Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
todo removal
mziolekda
reviewed
Feb 17, 2023
ledger-api/grpc-definitions/com/daml/ledger/api/v1/admin/identity_provider_config_service.proto
Outdated
Show resolved
Hide resolved
…ity_provider_config_service.proto Co-authored-by: mziolekda <marcin.ziolek@digitalasset.com>
mziolekda
reviewed
Feb 17, 2023
...-api/src/main/scala/platform/apiserver/services/admin/ApiIdentityProviderConfigService.scala
Outdated
Show resolved
Hide resolved
mziolekda
reviewed
Feb 17, 2023
mziolekda
reviewed
Feb 17, 2023
|
|
||
| it should "deny calls with user token for 'unknown_user' without expiration" taggedAs adminSecurityAsset | ||
| .setAttack( | ||
| attackPermissionDenied(threat = "Present a user JWT for 'unknown_user' without expiration") |
There was a problem hiding this comment.
What is the deciding factor for this threat to be permission_denied and for others to be unauthenticated?
There was a problem hiding this comment.
Somehow this is what was there in the impl before. Depending on which layer authorization fails - it gives either permission denied or unauthenticated. Permission denied usually is thrown when something has been correctly provided. "Aud" claim check happens during parsing of the token, so it fails very early which is why it throws "unauthenticated"
mziolekda
reviewed
Feb 17, 2023
skisel-da
requested review from
meiersi-da and
remyhaemmerle-da
as code owners
mziolekda
approved these changes
Feb 27, 2023
dasormeter
pushed a commit
that referenced
this pull request
Mar 30, 2023
dasormeter
added a commit
that referenced
this pull request
Mar 30, 2023
…6.x (#16631) * Add identity provider config to ledger client (#16625) * IdentityProviderConfigService through ledger client: create config * IdentityProviderConfigService through ledger client: get config * IdentityProviderConfigService through ledger client: list configs * IdentityProviderConfigService through ledger client: delete config * Fix updating of the audience field in IDP (#16630) * Customizable JWT audiences (#16330) --------- Co-authored-by: mziolekda <marcin.ziolek@digitalasset.com> Co-authored-by: Sergey Kisel <98825453+skisel-da@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.