Fix various issues with the reference daml-on-x implementation #1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add authorization check to submission to catch authorization errors early - Fix filtering by templates in transaction service - Loosen the transaction_id validation to accept transaction_ids as used by the reference implementation - Fix handling of ledger end - Add caching to archive decoding - Enable TransactionIT for the reference implementation - Fix time service event dedup
mziolekda
reviewed
Jun 12, 2019
| @@ -144,7 +144,6 @@ class TransactionServiceRequestValidator( | |||
| req: GetTransactionByIdRequest): Result[transaction.GetTransactionByIdRequest] = { | |||
| for { | |||
| ledgerId <- matchId(LedgerId(req.ledgerId)) | |||
| _ <- requireNumber(req.transactionId, "transaction_id") | |||
There was a problem hiding this comment.
Is this line related to failing tests?
…on ids would be verified as numbers by the api validation layer
… event id is used to fetch transactions
gerolf-da
previously requested changes
Jun 13, 2019
...ain/scala/com/digitalasset/platform/sandbox/services/transaction/ApiTransactionService.scala
Show resolved
Hide resolved
...ain/scala/com/digitalasset/platform/sandbox/services/transaction/ApiTransactionService.scala
Show resolved
Hide resolved
ghost
dismissed
gerolf-da’s stale review
100% agree on your review, we'll need to fix that in another PR though
ghost
mentioned this pull request
|
@gerolf-da follow up issue: #1638. |
gleber-da
approved these changes
Jun 13, 2019
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the reference implementation
Pull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.