Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename telemetry to tracing [PLEN-70] #16073

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Rename telemetry to tracing [PLEN-70] #16073

merged 1 commit into from
Jan 17, 2023

Conversation

nicu-da
Copy link
Contributor

@nicu-da nicu-da commented Jan 16, 2023

Telemetry contains both metrics and tracing, and we make a clear distinction between them in our modules. This will allow us to add a telemetry submodule that contains code used to setup the OpenTelemetry library.

@nicu-da
Rename telemetry to tracing
d4b85fd 
Telemetry contains both metrics and tracing, and we make a clear distinction between them in our modules.
This will allow us to add a telemetry submodule that contains code used to setup the OpenTelemetry library.
remyhaemmerle-da
remyhaemmerle-da reviewed Jan 16, 2023
View reviewed changes
Copy link
Collaborator

@remyhaemmerle-da remyhaemmerle-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine with triggers changes

lucb-da
lucb-da reviewed Jan 16, 2023
View reviewed changes
Copy link

@lucb-da lucb-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The classes Telemetry and TelemetryContext likely should be renamed too. With their tests.
The current Tracing class only contain helper methods, so maybe it should be renamed Utils or something like that..

@miklos-da
Copy link
Contributor

miklos-da commented Jan 16, 2023 •
edited by nicu-da
Loading

The classes Telemetry and TelemetryContext likely should be renamed too. With their tests.

I do agree, however, in order to keep the changes easier to comprehend I'd suggest doing those renames in a follow-up PR.

The current Tracing class only contain helper methods, so maybe it should be renamed Utils or something like that..

I would suggest keeping the current name or maybe renaming it to TracingMetadata to be even more specific. I.e., 'utils' is just a too generic name that doesn't capture the purpose of the methods contained therein.

@nicu-da nicu-da merged commit f370124 into main Jan 17, 2023
@nicu-da nicu-da deleted the nicuda/plen-72/rename_telemetry_to_tracing branch January 17, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucb-da lucb-da lucb-da left review comments

@remyhaemmerle-da remyhaemmerle-da remyhaemmerle-da left review comments

@miklos-da miklos-da miklos-da approved these changes

@ray-roestenburg-da ray-roestenburg-da Awaiting requested review from ray-roestenburg-da

@S11001001 S11001001 Awaiting requested review from S11001001

@garyverhaegen-da garyverhaegen-da Awaiting requested review from garyverhaegen-da

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicu-da @miklos-da @remyhaemmerle-da @lucb-da