Metering clarifications for Daml Hub [DPP-1314] #15898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonmaxen-da
changed the title
simonmaxen-da
changed the title
* Add metering report JSON schema * Remove metering-report-schema from proto exclusion list * Add header to metering report validator * Rename struct-json to struct-spray-json * Add struct-circe-json
simonmaxen-da
force-pushed
the
metring-schema
branch
from
0922310 to
3572ea5
Compare
simonmaxen-da
requested review from
ray-roestenburg-da,
a team,
meiersi-da and
garyverhaegen-da
as code owners
mziolekda
reviewed
Dec 15, 2022
| /** The metering report validation app can be used to verify that a provided metering report is consistent with | ||
| * a `check` section within the report. When the report is created the check section is populated with a digest | ||
| * and a scheme that was used in the creation of that digest. Different schemes may be used by different | ||
| * schemes (e.g. community verses enterprise) and for different point in time. |
There was a problem hiding this comment.
Different schemes may be used by different schemes
Consider rephrasing
mziolekda
reviewed
Dec 15, 2022
ledger/metering-verification/src/app/scala/com/daml/ledger/metering/Main.scala
Outdated
Show resolved
Hide resolved
mziolekda
reviewed
Dec 15, 2022
...truct-json/struct-circe-json/src/main/scala/com/daml/struct/circe/StructEncoderDecoder.scala
Show resolved
Hide resolved
simonmaxen-da
force-pushed
the
metring-schema
branch
from
4b18655 to
bf84098
Compare
mziolekda
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.