Document syntactic restriction for ids in ledger-api proto #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remyhaemmerle-da
added
component/daml-lf
remyhaemmerle-da
force-pushed
the
ledger-api-proto-doc
branch
from
2fc8749 to
1b0a43a
Compare
gerolf-da
requested changes
Jun 11, 2019
ledger-api/grpc-definitions/com/digitalasset/ledger/api/v1/command_completion_service.proto
Outdated
Show resolved
Hide resolved
ledger-api/grpc-definitions/com/digitalasset/ledger/api/v1/event.proto
Outdated
Show resolved
Hide resolved
ledger-api/grpc-definitions/com/digitalasset/ledger/api/v1/event.proto
Outdated
Show resolved
Hide resolved
ledger-api/grpc-definitions/com/digitalasset/ledger/api/v1/event.proto
Outdated
Show resolved
Hide resolved
ledger-api/grpc-definitions/com/digitalasset/ledger/api/v1/event.proto
Outdated
Show resolved
Hide resolved
ledger-api/grpc-definitions/com/digitalasset/ledger/api/v1/transaction_service.proto
Outdated
Show resolved
Hide resolved
ledger-api/grpc-definitions/com/digitalasset/ledger/api/v1/value.proto
Outdated
Show resolved
Hide resolved
ledger-api/grpc-definitions/com/digitalasset/ledger/api/v1/value.proto
Outdated
Show resolved
Hide resolved
ledger-api/grpc-definitions/com/digitalasset/ledger/api/v1/value.proto
Outdated
Show resolved
Hide resolved
ledger-api/grpc-definitions/com/digitalasset/ledger/api/v1/value.proto
Outdated
Show resolved
Hide resolved
remyhaemmerle-da
force-pushed
the
ledger-api-proto-doc
branch
3 times, most recently
from
ca6556d to
cc04991
Compare
gerolf-da
approved these changes
Jun 11, 2019
cocreature
force-pushed
the
ledger-api-proto-doc
branch
from
cc04991 to
10608c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We document the syntactic restriction about string identifiers in the ledger api protobuf file
Pull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.