[Speedy] create Scenario Machine #15588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remyhaemmerle-da
requested review from
basvangijzel-DA,
akrmn and
dylant-da
as code owners
remyhaemmerle-da
force-pushed
the
remy-lf-machine
branch
from
f7ac935 to
7820a47
Compare
remyhaemmerle-da
force-pushed
the
remy-lf-machine
branch
4 times, most recently
from
dceaf55 to
e38bc6f
Compare
| @@ -958,10 +979,10 @@ private[lf] object SBuiltin { | |||
| * -> CachedContract | |||
| * -> ContractId arg | |||
| */ | |||
| final case object SBUCreate extends OnLedgerBuiltin(2) { | |||
| override protected def executeWithLedger( | |||
| final case object SBUCreate extends UpdateBuiltin(2) { | |||
There was a problem hiding this comment.
Nit pick: we obviously have a naming convention here (e.g. SBUXXX vs SBXXX vs SBSXXX - would there be any value in documenting this desire within this file?
There was a problem hiding this comment.
Ok, fair enough. Thanks for looking.
There was a problem hiding this comment.
Will do that in another PR.
carlpulley-da
approved these changes
Dec 15, 2022
remyhaemmerle-da
force-pushed
the
remy-lf-machine
branch
from
e38bc6f to
83c550c
Compare
remyhaemmerle-da
force-pushed
the
remy-lf-machine
branch
from
83c550c to
d14160b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.