Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed http_json_api metrics from ledger metrics [DPP-1307]. #15552

Merged
merged 3 commits into from
Nov 15, 2022
Merged

Removed http_json_api metrics from ledger metrics [DPP-1307]. #15552

merged 3 commits into from
Nov 15, 2022

Conversation

atriantafyllos-da
Copy link
Contributor

@atriantafyllos-da atriantafyllos-da commented Nov 11, 2022 •
edited
Loading

@atriantafyllos-da atriantafyllos-da self-assigned this Nov 12, 2022
mziolekda
mziolekda reviewed Nov 14, 2022
View reviewed changes
Copy link
Contributor

@mziolekda mziolekda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 2 minor comments. Let me know when addressed. Looks good!

@atriantafyllos-da
Copy link
Contributor Author

Left 2 minor comments. Let me know when addressed. Looks good!

@mziolekda Addressed them.

lucb-da
lucb-da reviewed Nov 14, 2022
View reviewed changes
ledger-service/metrics/src/main/scala/com/digitalasset/http/metrics/HttpJsonApiMetrics.scala Outdated
val registry: MetricRegistry,
val otelMeter: OtelMeter,
) {
) extends DropwizardFactory {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the reasons for HttpJsonApiMetrics to extend DropwizardFactory ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason, I overlooked that the subsequent timers are created by a DropwizardFactory defined into the class.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing it.

@atriantafyllos-da atriantafyllos-da force-pushed the DPP-1307-move-json-http-metrics-to-ledger-client branch from 7b9c6cc to 1918455 Compare November 15, 2022 09:21
@atriantafyllos-da
Copy link
Contributor Author

rebased

mziolekda
mziolekda approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@mziolekda mziolekda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, removing those dependencies is a positive move at any measure.

nicu-da
nicu-da approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@nicu-da nicu-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@atriantafyllos-da atriantafyllos-da merged commit 5ddd064 into main Nov 15, 2022
@atriantafyllos-da atriantafyllos-da deleted the DPP-1307-move-json-http-metrics-to-ledger-client branch November 15, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicu-da nicu-da nicu-da approved these changes

@mziolekda mziolekda mziolekda approved these changes

@ray-roestenburg-da ray-roestenburg-da Awaiting requested review from ray-roestenburg-da

@remyhaemmerle-da remyhaemmerle-da Awaiting requested review from remyhaemmerle-da

@gerolf-da gerolf-da Awaiting requested review from gerolf-da

@lucb-da lucb-da Awaiting requested review from lucb-da

Assignees

@atriantafyllos-da atriantafyllos-da

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atriantafyllos-da @mziolekda @lucb-da @nicu-da