Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[script] rename: queryView --> queryInterface #15541

Merged
merged 1 commit into from
Nov 11, 2022
Merged

[script] rename: queryView --> queryInterface #15541

merged 1 commit into from
Nov 11, 2022

Conversation

nickchapman-da
Copy link
Contributor

Improve name for new daml-script functions:

  • queryInterface and queryInterfaceContractId

Advances #14830

@nickchapman-da nickchapman-da marked this pull request as ready for review November 11, 2022 09:41
basvangijzel-DA
basvangijzel-DA approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@basvangijzel-DA basvangijzel-DA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quickly doing this!

@nickchapman-da nickchapman-da merged commit 7abbb69 into main Nov 11, 2022
@nickchapman-da nickchapman-da deleted the nick/rename-queryView-to-queryInterface branch November 11, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvangijzel-DA basvangijzel-DA basvangijzel-DA approved these changes

@remyhaemmerle-da remyhaemmerle-da Awaiting requested review from remyhaemmerle-da

@akrmn akrmn Awaiting requested review from akrmn

@dylant-da dylant-da Awaiting requested review from dylant-da

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickchapman-da @basvangijzel-DA