Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid errors due to unhandled requests in VSCode #1538

Merged
merged 1 commit into from
Jun 6, 2019
Merged

Avoid errors due to unhandled requests in VSCode #1538

merged 1 commit into from
Jun 6, 2019

Conversation

cocreature
Copy link
Contributor

Pull Request Checklist

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@cocreature cocreature requested a review from a user June 6, 2019 05:42
@cocreature cocreature force-pushed the unhandled-requests branch from 140b7cf to 0059c33 Compare June 6, 2019 07:05
hurryabit
hurryabit approved these changes Jun 6, 2019
View reviewed changes
Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks.

@cocreature cocreature merged commit 4537a93 into master Jun 6, 2019
neil-da
neil-da reviewed Jun 6, 2019
View reviewed changes
Copy link
Contributor

@neil-da neil-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@dasormeter dasormeter deleted the unhandled-requests branch September 4, 2019 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neil-da neil-da neil-da left review comments

@hurryabit hurryabit hurryabit approved these changes

@bethaitman bethaitman Awaiting requested review from bethaitman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cocreature @hurryabit @neil-da