Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove yarn resolutions #15259

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Remove yarn resolutions #15259

merged 1 commit into from
Oct 19, 2022

Conversation

fayi-da
Copy link
Contributor

@fayi-da fayi-da commented Oct 17, 2022 •
edited by S11001001
Loading

Part of #13383.

@fayi-da
Remove yarn resolutions
4eac0eb 
CHANGELOG_BEGIN
CHANGELOG_END
S11001001
S11001001 approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@S11001001 S11001001 left a comment •
edited by fayi-da
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Questions before merging:

  • yarn audit still passes in both directories?
  • Does Navigator front-end still work according to a quick smoke-test in this branch?

@S11001001 S11001001 added component/navigator dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code gardening Cleanup code, improve tests, better automation, upgrade deps, fix flaky tests, address TODOs, etc. labels Oct 17, 2022
@stefanobaghino-da
Copy link
Contributor

Questions before merging:

  • yarn audit still passes in both directories?
  • Does Navigator front-end still work according to a quick smoke-test in this branch?

Could be worth running yarn audit automatically as part of automated tests to make sure this question doesn't need to be answered manually.

@fayi-da
Copy link
Contributor Author

fayi-da commented Oct 17, 2022

yarn audit works fine but I can do some testing on navigator to answer that second question

@S11001001 S11001001 added the team/ledger-clients Related to the Ledger Clients team's components. label Oct 17, 2022
@fayi-da
Copy link
Contributor Author

fayi-da commented Oct 18, 2022

@ray-roestenburg-da I think I an only merge this after your approval

@stefanobaghino-da
Copy link
Contributor

@ray-roestenburg-da I think I an only merge this after your approval

You don't have to, you only need one approval to merge. We use the CODEOWNERS for visibility, not to mandate certain approvals. Any other merge requirements are handled informally.

@fayi-da fayi-da merged commit a462277 into main Oct 19, 2022
@fayi-da fayi-da deleted the npm-resolutions branch October 19, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ray-roestenburg-da ray-roestenburg-da ray-roestenburg-da approved these changes

@S11001001 S11001001 S11001001 approved these changes

Assignees

@fayi-da fayi-da

Labels
component/navigator dependencies Pull requests that update a dependency file gardening Cleanup code, improve tests, better automation, upgrade deps, fix flaky tests, address TODOs, etc. javascript Pull requests that update Javascript code team/ledger-clients Related to the Ledger Clients team's components.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fayi-da @stefanobaghino-da @S11001001 @ray-roestenburg-da