removing ledger backend module #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabor-aranyossy
force-pushed
the
removing-ledger-backend
branch
from
827af11 to
554a078
Compare
gabor-aranyossy
force-pushed
the
removing-ledger-backend
branch
from
554a078 to
838c666
Compare
gabor-aranyossy
added this to the Integrate DAML-on-X interfaces in sandbox codebase milestone
gerolf-da
reviewed
Jun 5, 2019
| }, | ||
| inclusive = true // we need this to be inclusive otherwise the stream will be hanging until a new element from upstream arrives | ||
| ) | ||
| .filter(_.offset.toLong < end.toLong) | ||
| .filter(_._1 < end.toLong) | ||
| } | ||
| // we MUST do the offset comparison BEFORE collecting only the accepted transactions, |
There was a problem hiding this comment.
Please update the comment with the changes (e.g. the concept of "accepted transaction" doesn't exist anymore).
...box/src/main/scala/com/digitalasset/platform/sandbox/stores/ledger/SandboxIndexService.scala
Show resolved
Hide resolved
| @@ -23,7 +22,8 @@ import scala.collection.breakOut | |||
| trait TransactionConversion { | |||
|
|
|||
| def acceptedToDomainFlat( | |||
There was a problem hiding this comment.
Please rename from acceptedToDomainFlat to something like ledgerEntryTxToDomainFlat.
| filteredEvents, | ||
| domain.LedgerOffset.Absolute(trans.offset), | ||
| offset, | ||
| None | ||
| )) | ||
| } else None | ||
| } | ||
|
|
||
| def acceptedToDomainTree( |
...er/participant-state/src/main/scala/com/daml/ledger/participant/state/v1/SubmitterInfo.scala
Outdated
Show resolved
Hide resolved
…ipant/state/v1/SubmitterInfo.scala Co-Authored-By: Gary Verhaegen <gary.verhaegen@digitalasset.com>
|
@garyverhaegen-da @gerolf-da your comments have been addressed |
gerolf-da
approved these changes
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the unnecessary
ledger-backendmodule/abstraction.Pull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.